Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compliation for -Wsign-compare #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

LIBA-S
Copy link

@LIBA-S LIBA-S commented Jun 9, 2022

avoid compiler warning

@google-cla
Copy link

google-cla bot commented Jun 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ilya-lavrenov
Copy link

Can we merge this change?
It allows to overcome -Wextra issue with clang compiler.

@leleliu008
Copy link

I encountered this on macOS:

2023-07-10T23:21:35.3404040Z /Users/runner/.xcpkg/run/5437/snappy/src/snappy.cc:1293:37: error: comparison of integers of different signs: 'unsigned long' and 'ptrdiff_t' (aka 'long') [-Werror,-Wsign-compare]
2023-07-10T23:21:35.3404560Z              (op + deferred_length) < op_limit_min_slop);
2023-07-10T23:21:35.3404850Z               ~~~~~~~~~~~~~~~~~~~~  ^ ~~~~~~~~~~~~~~~~~
2023-07-10T23:21:35.3405480Z /Users/runner/.xcpkg/run/5437/snappy/src/snappy.cc:1293:37: error: comparison of integers of different signs: 'unsigned long' and 'ptrdiff_t' (aka 'long') [-Werror,-Wsign-compare]
2023-07-10T23:21:35.3405990Z              (op + deferred_length) < op_limit_min_slop);

@thalesmg
Copy link

I encountered this on macOS:

2023-07-10T23:21:35.3404040Z /Users/runner/.xcpkg/run/5437/snappy/src/snappy.cc:1293:37: error: comparison of integers of different signs: 'unsigned long' and 'ptrdiff_t' (aka 'long') [-Werror,-Wsign-compare]
2023-07-10T23:21:35.3404560Z              (op + deferred_length) < op_limit_min_slop);
2023-07-10T23:21:35.3404850Z               ~~~~~~~~~~~~~~~~~~~~  ^ ~~~~~~~~~~~~~~~~~
2023-07-10T23:21:35.3405480Z /Users/runner/.xcpkg/run/5437/snappy/src/snappy.cc:1293:37: error: comparison of integers of different signs: 'unsigned long' and 'ptrdiff_t' (aka 'long') [-Werror,-Wsign-compare]
2023-07-10T23:21:35.3405990Z              (op + deferred_length) < op_limit_min_slop);

I ran into this issue as well. It seems they fixed it after release 1.1.10: 27f34a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants