Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues reported by lintian #123

Open
wants to merge 7 commits into
base: debian
Choose a base branch
from

Conversation

debian-janitor
Copy link

@debian-janitor debian-janitor commented Mar 13, 2021

Fix some issues reported by lintian

Debdiff

These changes affect the binary packages:

[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second set of .debs but not in first

-rw-r--r--  root/root   /usr/lib/debug/.build-id/09/de75c5cc2482ef0eb25614382272df74248b3b.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/10/e2c507085771944912258d841499b207a45bc6.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/26/9806b0d9d695d03f36ccd4dabcb32d10420f23.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/52/e3ca13c53ada527f9dba744caf0bd63d209cb5.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/60/bf61be0533143b97d957ce5f559fa576eaa42b.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/87/0a697e6c195c43e4e5afedbbe2f92fa62f4b3e.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/c5/52eec5fa216762f663b358aed0809a7c1735da.debug

Files in first set of .debs but not in second

-rw-r--r--  root/root   /usr/lib/debug/.build-id/14/aac29174c1cfef316f46b971ccd100da3135de.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/2c/34e07dfec23189e665401d88c7bc35f68fef52.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/67/50a759e3208a8345d0c9a5610e9d7047dc5989.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/8a/28c708edf4d317f06720ee34e823dc4f907b19.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/b6/9d534780485130ee38813bd4045a619f3d5582.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/bb/05190b2b56a72ef6dbdaa23c67e1058706fd9a.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/ee/e8ff5406f294a7e74cc65b11be242bcc56c960.debug

No differences were encountered between the control files of package **xsecurelock**

Control files of package xsecurelock-dbgsym: lines which differ (wdiff format)

  • Build-Ids: [-14aac29174c1cfef316f46b971ccd100da3135de 2c34e07dfec23189e665401d88c7bc35f68fef52 6750a759e3208a8345d0c9a5610e9d7047dc5989 8a28c708edf4d317f06720ee34e823dc4f907b19 b69d534780485130ee38813bd4045a619f3d5582 bb05190b2b56a72ef6dbdaa23c67e1058706fd9a eee8ff5406f294a7e74cc65b11be242bcc56c960-] {+09de75c5cc2482ef0eb25614382272df74248b3b 10e2c507085771944912258d841499b207a45bc6 269806b0d9d695d03f36ccd4dabcb32d10420f23 52e3ca13c53ada527f9dba744caf0bd63d209cb5 60bf61be0533143b97d957ce5f559fa576eaa42b 870a697e6c195c43e4e5afedbbe2f92fa62f4b3e c552eec5fa216762f663b358aed0809a7c1735da+}

You can also view the diffoscope diff (unfiltered).

This merge proposal was created by the Janitor bot, and it will automatically rebase or close this proposal as appropriate when the target branch changes. Any comments you leave here will be read by the Janitor's maintainers.

Build and test logs for this branch can be found at https://janitor.debian.net/lintian-fixes/pkg/xsecurelock/26f486c2-1436-421d-ba3c-1ab24c6db8f7.

@google-cla
Copy link

google-cla bot commented Mar 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@schachmat
Copy link
Member

@jelmer if I understand correctly, you're the author of this bot. Would it be possible at all to sign the CLA as the bot? If not, we'll probably need to deny this and fix lintian issues manually whenever we encounter them.

@jelmer
Copy link

jelmer commented Mar 15, 2021

Hi @schachmat,

I'm indeed one of the contacts for the Debian janitor. IANAL but I don't think the bot can legally sign things. It's not just a tool I run (making it another identity of me) - it's a cron job that runs on GCP and doesn't need manual interaction, and can be started by other people.

Closing the pull request is probably simplest. You can always run the lintian-brush command (packaged in Debian to make these changes yourself - though you wouldn't get the validation (building, running tests, diffing the binary packages) that the bot does after running lintian-brush and before creating a pull request.

For the moment, I've excluded any repositories that require a CLA from receiving pull requests by the bot. If the situation changes, please let me know and I can undo that.

Jelmer

@google-cla
Copy link

google-cla bot commented Sep 24, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Changes-By: lintian-brush
Fixes: lintian: package-uses-old-debhelper-compat-version
See-also: https://lintian.debian.org/tags/package-uses-old-debhelper-compat-version.html
Changes-By: lintian-brush
Fixes: lintian: uses-debhelper-compat-file
See-also: https://lintian.debian.org/tags/uses-debhelper-compat-file.html
Changes-By: lintian-brush
Fixes: lintian: out-of-date-standards-version
See-also: https://lintian.debian.org/tags/out-of-date-standards-version.html
Changes-By: lintian-brush
Fixes: lintian: upstream-metadata-missing-bug-tracking
See-also: https://lintian.debian.org/tags/upstream-metadata-missing-bug-tracking.html
Fixes: lintian: upstream-metadata-missing-repository
See-also: https://lintian.debian.org/tags/upstream-metadata-missing-repository.html
Changes-By: lintian-brush
Fixes: lintian: out-of-date-standards-version
See-also: https://lintian.debian.org/tags/out-of-date-standards-version.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants