-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support resource_tags for table #2093
Conversation
732426d
to
e783909
Compare
Sorry, this seems to be a duplicate of #2090. |
Hi @Linchin , This PR was closed as a duplicate of #2090, but I’d like to clarify that #2090 addresses the resource tags for datasets, while this PR focuses on the resource tags for tables. Could you please reopen this PR for further review? Let me know if additional clarification is needed. |
Thank you @hrkh for clarifying! I have reopened and will review this PR. |
Thank you @hrkh for your contribution! It seems we just have the system test with python 3.12 failing, and it was caused by the same resource tag having been created by the python 3.8 system test. We encountered the exact same issue in #2090, and it was resolved by prefixing a randomly generated string to the tags (as in this commit). Could you see if you could implement this, so we can get this PR across the line? Cheers. |
Thank you @Linchin for your detailed feedback and guidance! I've updated the PR to append randomly generated strings as suffixes to the tag keys, following the approach used in the referenced commit. This should resolve the test failures with Python 3.12. Please let me know if any further adjustments are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Fixes #2089 🦕