This repository has been archived by the owner on Apr 24, 2021. It is now read-only.
Integrated editor with ContentProviders #3529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6873e64.
…ge events and navigation
…into umop-preferences-editor_with_providers
…h out of NavigationManager
…loseAction & invocations,
| @@ -298,6 +303,12 @@ class TextEditor extends Editor { | |||
| * @import url("packages/bootjack/css/bootstrap.min.css"); | |||
| */ | |||
| Future<svc.Declaration> _simpleNavigateToDeclaration([Duration timeLimit]) { | |||
| if (!(contentProvider is FileContentProvider)) { | |||
| throw "Can only navigate from [File]s for now"; | |||
There was a problem hiding this comment.
You could also fail in a non-fatal way:
return new Future.value(svc.Declaration.EMPTY_DECLARATION);
|
Awesome, a very, very thorough CL. Two things, in addition to the comments:
|
| void persistTab(File file) { | ||
| EditorTab tab = _tabOfFile[file]; | ||
| EditorTab _tabByUuid(String uuid) { | ||
| return _tabOfUuid.containsKey(uuid) ? _tabOfUuid[uuid] : null; |
There was a problem hiding this comment.
return _tabOfUuid[uuid]; would work as well.
|
let's circle back to this tuesday when you're back in the office |
…into umop-preferences-edit_preference_content_provider
|
@umop: where are we with this? Is this complete and usable as is, or is it a part of a prospected CL chain? If the latter, would you have 20% time to finish the whole thing off? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR, but was as small as I could manage. This integrates ContentProviders into the editor, NavigationManager, tabs, events, file selection (when dealing with files), file search, closing, and parts of rename.
Note: Commit 21d194f should have read: Handled tabs, events, comparator,
NavigationManager, and openFile instead ofTEMPFixes #3433
Review @devoncarew