Enabled sending of user properties (#310)

googlearchive · Apr 1, 2020 · 2f7a424 · 2f7a424
1 parent 682f92d
commit 2f7a424
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 7.2.2-dev
+
+- Enabled sending of user properties in analytics with `setUserProperties`.
+- Removed unused (and unusable) `CustomParams` class.
+
 ## 7.2.1
 
 - Mark intereop types `AuthProvider` and `OAuthCredential` anonymous. 

diff --git a/lib/src/analytics.dart b/lib/src/analytics.dart
@@ -44,12 +44,12 @@ class Analytics extends JsObjectWrapper<analytics_interop.AnalyticsJsImpl> {
     }
   }
 
-  void setUserProperties(CustomParams properties,
+  void setUserProperties(Map<String, String> properties,
       [AnalyticsCallOptions options]) {
     if (options != null) {
-      jsObject.setUserProperties(properties.jsObject, options.jsObject);
+      jsObject.setUserProperties(jsify(properties), options.jsObject);
     } else {
-      jsObject.setUserProperties(properties.jsObject);
+      jsObject.setUserProperties(jsify(properties));
     }
   }
 }
@@ -65,9 +65,3 @@ class AnalyticsCallOptions
     jsObject.global = t;
   }
 }
-
-class CustomParams
-    extends JsObjectWrapper<analytics_interop.CustomParamsJsImpl> {
-  CustomParams._fromJsObject(analytics_interop.CustomParamsJsImpl jsObject)
-      : super.fromJsObject(jsObject);
-}
diff --git a/lib/src/interop/analytics_interop.dart b/lib/src/interop/analytics_interop.dart
@@ -11,7 +11,7 @@ abstract class AnalyticsJsImpl {
   external void setCurrentScreen(String screenName,
       [AnalyticsCallOptionsJsImpl options]);
   external void setUserId(String id, [AnalyticsCallOptionsJsImpl options]);
-  external void setUserProperties(CustomParamsJsImpl properties,
+  external void setUserProperties(Object properties,
       [AnalyticsCallOptionsJsImpl options]);
 }
 
@@ -23,8 +23,3 @@ class AnalyticsCallOptionsJsImpl {
 
   external factory AnalyticsCallOptionsJsImpl({bool global});
 }
-
-@JS('CustomParams')
-class CustomParamsJsImpl {
-  //TODO: implement
-}
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: firebase
 description: Firebase libraries for Dart on the web and server
-version: 7.2.1
+version: 7.2.2-dev
 homepage: https://github.com/FirebaseExtended/firebase-dart
 
 environment: