Rename argument to avoid confustion with other 'options' arguments

googlefonts · Jan 16, 2025 · 1a570f9 · 1a570f9
1 parent 99df272
commit 1a570f9
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/fontra/client/core/ui-utils.js b/src/fontra/client/core/ui-utils.js
@@ -179,9 +179,9 @@ export function labeledTextInput(label, controller, key, options) {
   return items;
 }
 
-export function popupSelect(controller, key, options) {
+export function popupSelect(controller, key, popupItems) {
   function findLabel() {
-    const option = options.find(({ value }) => value === controller.model[key]);
+    const option = popupItems.find(({ value }) => value === controller.model[key]);
     return option?.label || "";
   }
 
@@ -190,7 +190,7 @@ export function popupSelect(controller, key, options) {
   });
 
   const menu = new PopupMenu(findLabel(), () =>
-    options.map(({ value, label }) => ({
+    popupItems.map(({ value, label }) => ({
       title: label,
       checked: value === controller.model[key],
       callback: () => {
@@ -202,8 +202,8 @@ export function popupSelect(controller, key, options) {
   return menu;
 }
 
-export function labeledPopupSelect(label, controller, key, options) {
-  const inputElement = popupSelect(controller, key, options);
+export function labeledPopupSelect(label, controller, key, popupItems) {
+  const inputElement = popupSelect(controller, key, popupItems);
   return [labelForElement(label, inputElement), inputElement];
 }