Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve detection of unset API keys #31

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

dkhawk
Copy link
Collaborator

@dkhawk dkhawk commented Jan 7, 2025

Improvements to the detection of unset API keys, providing clearer error messages and guidance to developers.

The PlacesAutocompleteTextFieldTest has been updated to account for the new default line limits.

Updates the versions of the following dependencies:

  • MapsCompose
  • Places
  • AGP
  • Compose BOM
  • Kotlin
  • Material
  • Other dependencies as needed

Improvements to the detection of unset API keys, providing clearer error messages and guidance to developers.

The PlacesAutocompleteTextFieldTest has been updated to account for the new default line limits.

Updates the versions of the following dependencies:

* MapsCompose
* Places
* AGP
* Compose BOM
* Kotlin
* Material
* Other dependencies as needed
@dkhawk dkhawk requested a review from kikoso January 7, 2025 22:20
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but CI/CD still fails. This can probably be fixed by changing the Java environment in the GitHub runner.

@dkhawk dkhawk requested a review from a team as a code owner January 8, 2025 16:30
@googlemaps-bot
Copy link

Code Coverage

Overall Project 2.11%

There is no coverage information present for the Files changed

@dkhawk dkhawk merged commit 0289bb4 into main Jan 8, 2025
9 checks passed
@dkhawk dkhawk deleted the updates-for-release branch January 8, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants