Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump pyroscope-go/godeltaprof to v0.1.8 to fix panic on go 1.23 #1875

Closed
wants to merge 1 commit into from
Closed

Chore: Bump pyroscope-go/godeltaprof to v0.1.8 to fix panic on go 1.23 #1875

wants to merge 1 commit into from

Conversation

Antiz96
Copy link

@Antiz96 Antiz96 commented Sep 3, 2024

@Antiz96 Antiz96 requested a review from a team as a code owner September 3, 2024 17:34
@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@ivanahuckova
Copy link
Member

@Antiz96 thank you for your contribution. We appreciate it. It looks that in the meantime, we fixed this by https://github.com/grafana/grafana-zabbix/pull/1877/files. So closing this. But again, thank you. :)

@Antiz96
Copy link
Author

Antiz96 commented Sep 6, 2024

Alright, that's fine thanks! :)

Do you know if a new release including this fix is planned soon?
I'm the package maintainer for the grafana-zabbix Arch Linux package, so it's just to know if I can expect a new release I'll be able to build as-is or if I should backport those fixes into our current package (Arch is already on go 1.23).

@ivanahuckova
Copy link
Member

We can release next week, is that all right?

@Antiz96
Copy link
Author

Antiz96 commented Sep 6, 2024

Sure that'll do. Thanks again!

@ivanahuckova
Copy link
Member

New version of Zabbix v4.5.4 has been released.

@Antiz96
Copy link
Author

Antiz96 commented Sep 12, 2024

New version of Zabbix v4.5.4 has been released.

Alright! I can't see the tag yet but I assume that's coming 😄
Thanks a lot!

EDIT: I can see https://drone.grafana.net/grafana/grafana-zabbix/206 running, so that's indeed cooking 😛
EDIT2: Seems like the pipeline failed actually: https://drone.grafana.net/grafana/grafana-zabbix/206/1/5

@ivanahuckova
Copy link
Member

Yes, had a slight issue with releasing, but it is out now https://github.com/grafana/grafana-zabbix/tags! 🎉

@Antiz96
Copy link
Author

Antiz96 commented Sep 13, 2024

Thanks again 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fails with go 1.23 due to panic in pyroscope-go/godeltaprof v0.1.7
3 participants