Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump github.com/fsouza/fake-gcs-server to v.1.51.0 #15588

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tuftedocelot
Copy link
Contributor

Fixes building on OpenBSD

@tuftedocelot tuftedocelot requested a review from a team as a code owner January 4, 2025 04:21
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ paul1r
❌ tuftedocelot


tuftedocelot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tuftedocelot tuftedocelot force-pushed the update-fake-gcs-server branch from eaeaf38 to f2198a7 Compare January 4, 2025 04:26
@tuftedocelot
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
tuftedocelot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

I botched the initial git author config line, but that's fixed up now

@tuftedocelot
Copy link
Contributor Author

also sniped by #15589

Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you!

@ashwanthgoli ashwanthgoli changed the title Bump github.com/fsouza/fake-gcs-server to v.1.51.0 fix(deps): bump github.com/fsouza/fake-gcs-server to v.1.51.0 Jan 6, 2025
@ashwanthgoli
Copy link
Contributor

@tuftedocelot you need to sign the CLA before we can merge this :)
#15588 (comment)

@tuftedocelot
Copy link
Contributor Author

Hm, I thought I'd already done that. Should be good to go now?

@tuftedocelot
Copy link
Contributor Author

I'm not sure what's up with the CLA agreement, but it seems to be getting reset. I re-signed it again and see this:
image

@ashwanthgoli
Copy link
Contributor

@tuftedocelot looks like the commit is not from a github account? can you fix that.

@tuftedocelot
Copy link
Contributor Author

That should be fixed in the force-pushed commit. I had originally typoed the email address in git config, but fixed that, amended the commit, and then force-pushed it. I wonder if CLA bot is getting hung up on the first commit? 🤷

@paul1r
Copy link
Collaborator

paul1r commented Jan 10, 2025

I've tried updating this from main and forcing the CLA bot to recheck, but no joy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants