Support cache skipping for Load() calls that throw SkipCacheError
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncalvesnelson
force-pushed
the
feature/expose-panic-error-wrapper
branch
from
6bbc8d5 to
bf5efb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using a dataloader with a cache, errors returned by the
BatchFuncare stored in the cache.A user should be able to decide on caching errors depending on the error type (e.g. temporary errors when using caches with long ttl).
To support this use case, this PR adds a new error type
SkipCacheErroralong with theNewSkipCacheErrorconstructor function to allow users to wrap errors they don't want to be cached.