Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the pgShortPk comment in the README #2299

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

jcgsville
Copy link
Contributor

According to my testing, this comment was incorrect. I think this is correct, now?

The correction also aligns with @benjie's advice on discord:

https://discord.com/channels/489127045289476126/1325590053929484292/1325594053034901564

Copy link

changeset-bot bot commented Jan 5, 2025

🦋 Changeset detected

Latest commit: 6504a93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphile/simplify-inflection Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benjie benjie changed the title correct the pgShortPk comment in the readme Correct the pgShortPk comment in the README Jan 6, 2025
@benjie benjie merged commit a382bd9 into graphile:main Jan 6, 2025
21 checks passed
@jcgsville jcgsville deleted the simplify-inflection-readme-fix branch January 6, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants