Fix TFSchema generation where a OneOf has a lower-case name #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
requested review from
klizhentas,
russjones and
r0mant
as code owners
strideynet
changed the title
tigrato
approved these changes
Dec 30, 2024
hugoShaka
approved these changes
Jan 9, 2025
Closed
This was referenced Jan 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating tfschema for RFD153 compliant resources with a oneof, the protoc-gen-terraform does not properly generate the exported field name based on the lower-snake name of the oneof:
This PR attempts to correct this. I've also modified the test suite to fail more usefully.