[MAINTENANCE] Remove util functions from public API (#10557)

great-expectations · Oct 24, 2024 · 16e41e6 · 16e41e6
1 parent 2b49e89
commit 16e41e6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/docs/sphinx_api_docs_source/public_api_missing_threshold.py b/docs/sphinx_api_docs_source/public_api_missing_threshold.py
@@ -137,6 +137,10 @@
     "File: great_expectations/render/renderer/site_builder.py Name: DefaultSiteIndexBuilder",
     "File: great_expectations/render/renderer/site_builder.py Name: SiteBuilder",
     "File: great_expectations/render/renderer/slack_renderer.py Name: SlackRenderer",
+    "File: great_expectations/render/util.py Name: handle_strict_min_max",
+    "File: great_expectations/render/util.py Name: num_to_str",
+    "File: great_expectations/render/util.py Name: parse_row_condition_string_pandas_engine",
+    "File: great_expectations/render/util.py Name: substitute_none_for_missing",
     "File: great_expectations/validator/metric_configuration.py Name: MetricConfiguration",
     "File: great_expectations/validator/metrics_calculator.py Name: columns",
     "File: great_expectations/validator/validation_graph.py Name: resolve",

diff --git a/great_expectations/render/util.py b/great_expectations/render/util.py
@@ -10,7 +10,6 @@
 
 import pandas as pd
 
-from great_expectations._docs_decorators import public_api
 from great_expectations.data_context.types.resource_identifiers import (
     ValidationResultIdentifier,
 )
@@ -23,7 +22,6 @@
 ctx.prec = DEFAULT_PRECISION
 
 
-@public_api
 def num_to_str(  # noqa: C901
     f: float,
     precision: int = DEFAULT_PRECISION,
@@ -121,7 +119,6 @@ def resource_key_passes_run_name_filter(resource_key, run_name_filter):
         return regex_match is not None
 
 
-@public_api
 def substitute_none_for_missing(
     kwargs: dict[str, Any], kwarg_list: Sequence[str]
 ) -> dict[str, Any]:
@@ -155,7 +152,6 @@ def substitute_none_for_missing(
 
 
 # NOTE: the method is pretty dirty
-@public_api
 def parse_row_condition_string_pandas_engine(
     condition_string: str, with_schema: bool = False
 ) -> tuple[str, dict]:
@@ -223,7 +219,6 @@ def parse_row_condition_string_pandas_engine(
     return template_str, params
 
 
-@public_api
 def handle_strict_min_max(params: dict) -> tuple[str, str]:
     """Utility function for the at least and at most conditions based on strictness.
 

diff --git a/great_expectations/util.py b/great_expectations/util.py
@@ -46,7 +46,6 @@
 from dateutil.parser import parse
 from packaging import version
 
-from great_expectations._docs_decorators import public_api
 from great_expectations.compatibility import pydantic, pyspark, sqlalchemy
 from great_expectations.compatibility.sqlalchemy import LegacyRow, Row
 from great_expectations.compatibility.sqlalchemy import sqlalchemy as sa
@@ -1181,7 +1180,6 @@ def convert_to_json_serializable(
 ) -> None: ...
 
 
-@public_api  # - complexity 32
 def convert_to_json_serializable(  # noqa: C901, PLR0911, PLR0912
     data: JSONConvertable,
 ) -> JSONValues: