Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMAKE minimum version to 2.8.12 #1403

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

smburdick
Copy link
Contributor

To remove the CMAKE build deprecation warning, update the minimum required version.

@miek
Copy link
Member

miek commented Feb 1, 2024

Could this be updated to 2.8.12 as the warning suggests, or is there a reason why it should be updated to a higher version?

@smburdick
Copy link
Contributor Author

Could this be updated to 2.8.12 as the warning suggests, or is there a reason why it should be updated to a higher version?

It could. I had no reason to make it that specific version. I can retry with 2.8.12.

@smburdick smburdick changed the title Update CMAKE minimum version to 3.1.3 Update CMAKE minimum version to 2.8.12 Feb 1, 2024
@martinling
Copy link
Member

The minimum supported version has been bumped again, so we now get:

 CMake Deprecation Warning at libhackrf/CMakeLists.txt:24 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of CMake.

I guess we can probably bump to 3.5 at this point (released 2016).

@mossmann
Copy link
Member

I think 2.8.12 is good enough for today's release. Thank you for the contribution!

@mossmann mossmann merged commit d0bb896 into greatscottgadgets:master Feb 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants