-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving GMT to microjoules #932
Conversation
Eco-CI Output:
❌ CO2 Data: |
…esolution to phase_stats
…Reworked transformation of values and units
…ergy; added new tests for SR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
47 file(s) reviewed, 39 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
45 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
* main: (58 commits) (Data): Added more metric mappings for nice display in frontend (Fix): Made functions that return data non-async and functions that operate independently async Added phase stats uJ migration Updated Cloud Energy Deactivated test for now Moving GMT to microjoules (#932) Measurement table split (#1039) (fix): end measurement can appear twice in notes, which is superflous No need for strict null check Bump orjson from 3.10.12 to 3.10.13 (#1037) Bump anybadge from 1.14.0 to 1.15.6 (#1038) Metric importer refactor (#1035) (improvement): Added ICMP, Ehterframe, QUIC and TCP-Streams to TCPDump [skip ci] (#1036) Removed the email column from the runs table (change): Changed default resolution of powermetrics to a non-underflow resolution Bump uvicorn-worker from 0.2.0 to 0.3.0 (#1034) (fix): lmsensors was not reacting to skip_check (Tests): pytest running as default with -vv (fix): Tests. Locator adapted to new default table sorting of CI repos (style): Better error message ...
* main: (58 commits) (Data): Added more metric mappings for nice display in frontend (Fix): Made functions that return data non-async and functions that operate independently async Added phase stats uJ migration Updated Cloud Energy Deactivated test for now Moving GMT to microjoules (#932) Measurement table split (#1039) (fix): end measurement can appear twice in notes, which is superflous No need for strict null check Bump orjson from 3.10.12 to 3.10.13 (#1037) Bump anybadge from 1.14.0 to 1.15.6 (#1038) Metric importer refactor (#1035) (improvement): Added ICMP, Ehterframe, QUIC and TCP-Streams to TCPDump [skip ci] (#1036) Removed the email column from the runs table (change): Changed default resolution of powermetrics to a non-underflow resolution Bump uvicorn-worker from 0.2.0 to 0.3.0 (#1034) (fix): lmsensors was not reacting to skip_check (Tests): pytest running as default with -vv (fix): Tests. Locator adapted to new default table sorting of CI repos (style): Better error message ...
@greptileai
Greptile Summary
This PR implements a significant database schema change and standardizes energy measurements to use microjoules (uJ) across the Green Metrics Tool.
/tests/lib/test_phase_stats.py
with sampling rate validationMICROJOULES_TO_KWH
in/tests/lib/test_phase_stats.py
/tests/data/metrics/network_io_procfs_system.log
for network I/O metrics validation/tests/metric_providers/test_metric_providers.py
for improved precision/migrations/2023_07_10_indices.sql