Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving GMT to microjoules #932

Merged
merged 26 commits into from
Jan 4, 2025
Merged

Moving GMT to microjoules #932

merged 26 commits into from
Jan 4, 2025

Conversation

ArneTR
Copy link
Member

@ArneTR ArneTR commented Oct 3, 2024

@greptileai

Greptile Summary

This PR implements a significant database schema change and standardizes energy measurements to use microjoules (uJ) across the Green Metrics Tool.

  • Added network I/O metrics testing in /tests/lib/test_phase_stats.py with sampling rate validation
  • Updated energy unit conversion constant MICROJOULES_TO_KWH in /tests/lib/test_phase_stats.py
  • Added test data file /tests/data/metrics/network_io_procfs_system.log for network I/O metrics validation
  • Modified sampling rate from 100 to 1000 in /tests/metric_providers/test_metric_providers.py for improved precision
  • Removed phase column and index from measurements table in /migrations/2023_07_10_indices.sql

Copy link

Eco-CI Output:

Label 🖥 avg. CPU utilization [%] 🔋 Total Energy [Joules] 🔌 avg. Power [Watts] Duration [Seconds]
Total Run (incl. overhead) 26.6011 1954.89 4.02 486
Measurement #1 26.5669 1954.89 4.03 485

❌ CO2 Data:
Error in retrieving values. Please see the detailed logs for the exact error messages!

@ArneTR ArneTR marked this pull request as ready for review January 3, 2025 18:42
ArneTR added 2 commits January 4, 2025 02:43
* main:
  Measurement table split (#1039)
  (fix): end measurement can appear twice in notes, which is superflous
  No need for strict null check
  Bump orjson from 3.10.12 to 3.10.13 (#1037)
  Bump anybadge from 1.14.0 to 1.15.6 (#1038)
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

47 file(s) reviewed, 39 comment(s)
Edit PR Review Bot Settings | Greptile

api/main.py Outdated Show resolved Hide resolved
api/api_helpers.py Show resolved Hide resolved
api/api_helpers.py Outdated Show resolved Hide resolved
docker/structure.sql Outdated Show resolved Hide resolved
docker/structure.sql Outdated Show resolved Hide resolved
tests/lib/test_phase_stats.py Outdated Show resolved Hide resolved
tests/lib/test_phase_stats.py Show resolved Hide resolved
tests/smoke_test.py Show resolved Hide resolved
tests/smoke_test.py Show resolved Hide resolved
tools/calibrate.py Show resolved Hide resolved
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

45 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile

docker/structure.sql Outdated Show resolved Hide resolved
ee Show resolved Hide resolved
ee Show resolved Hide resolved
frontend/js/helpers/config.js.example Show resolved Hide resolved
frontend/js/helpers/converters.js Show resolved Hide resolved
tests/lib/test_phase_stats.py Show resolved Hide resolved
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

frontend/js/helpers/converters.js Show resolved Hide resolved
frontend/js/stats.js Show resolved Hide resolved
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@ArneTR ArneTR merged commit 2281f06 into main Jan 4, 2025
3 of 4 checks passed
@ArneTR ArneTR deleted the microjoules branch January 4, 2025 14:20
ArneTR added a commit that referenced this pull request Jan 6, 2025
* main: (58 commits)
  (Data): Added more metric mappings for nice display in frontend
  (Fix): Made functions that return data non-async and functions that operate independently async
  Added phase stats uJ migration
  Updated Cloud Energy
  Deactivated test for now
  Moving GMT to microjoules (#932)
  Measurement table split (#1039)
  (fix): end measurement can appear twice in notes, which is superflous
  No need for strict null check
  Bump orjson from 3.10.12 to 3.10.13 (#1037)
  Bump anybadge from 1.14.0 to 1.15.6 (#1038)
  Metric importer refactor (#1035)
  (improvement): Added ICMP, Ehterframe, QUIC and TCP-Streams to TCPDump [skip ci] (#1036)
  Removed the email column from the runs table
  (change): Changed default resolution of powermetrics to a non-underflow resolution
  Bump uvicorn-worker from 0.2.0 to 0.3.0 (#1034)
  (fix): lmsensors was not reacting to skip_check
  (Tests): pytest running as default with -vv
  (fix): Tests. Locator adapted to new default table sorting of CI repos
  (style): Better error message
  ...
ArneTR added a commit that referenced this pull request Jan 7, 2025
* main: (58 commits)
  (Data): Added more metric mappings for nice display in frontend
  (Fix): Made functions that return data non-async and functions that operate independently async
  Added phase stats uJ migration
  Updated Cloud Energy
  Deactivated test for now
  Moving GMT to microjoules (#932)
  Measurement table split (#1039)
  (fix): end measurement can appear twice in notes, which is superflous
  No need for strict null check
  Bump orjson from 3.10.12 to 3.10.13 (#1037)
  Bump anybadge from 1.14.0 to 1.15.6 (#1038)
  Metric importer refactor (#1035)
  (improvement): Added ICMP, Ehterframe, QUIC and TCP-Streams to TCPDump [skip ci] (#1036)
  Removed the email column from the runs table
  (change): Changed default resolution of powermetrics to a non-underflow resolution
  Bump uvicorn-worker from 0.2.0 to 0.3.0 (#1034)
  (fix): lmsensors was not reacting to skip_check
  (Tests): pytest running as default with -vv
  (fix): Tests. Locator adapted to new default table sorting of CI repos
  (style): Better error message
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant