Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied revision comments #7

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

Timanx
Copy link

@Timanx Timanx commented Sep 20, 2017

  • throw away error messages not fitting into interval
  • add optional warning about blind time after notification was sent
  • truncate long messages

Ondrej Bouda and others added 8 commits February 21, 2016 23:56
Configurable username to post the message as.
Configurable icon_emoji to post the message with.
Configurable message pretext.
Color message according to the priority.
Treat the logUrl configuration as optional.
Detailed documentation on configuration options.
* add optional warning about blind time after notification was sent
* truncate long messages
@greeny
Copy link
Owner

greeny commented Sep 22, 2017

Please check latest commit on master.
Most of this functionality is already implemented.
Also your commit rewrites stuff in readme, that is not related (e.g. changing name of vendor).

Please send PR with changes you want me to make only.

If you are ok with it, I will close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants