-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows support + docs, closes #22, closes #25 #23
Conversation
Reviewer's Guide by SourceryThis pull request adds Windows support to the project, including changes to the build system, CI pipeline, and documentation. The main changes involve modifying the CMakeLists.txt file to handle Windows-specific paths and commands, updating the GitHub Actions workflow to include Windows builds, and adding PowerShell scripts for Windows-specific build and clean operations. File-Level Changes
Sequence DiagramNo sequence diagram generated. Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @greynewell - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider keeping GCC in the build matrix for Linux to ensure compatibility with both major compiler families.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sweet, we at least have the same error on the client and server now:
|
The issue appears to be that the definition for |
Some success building and testing locally: Created #29 to get this fully sorted locally. |
release.ps1
scriptllama-server
in Bash scriptsWebBrowserComponent
related build errorsSummary by Sourcery
Add support for building and running the project on Windows by updating CMake configurations, adding PowerShell scripts for building and cleaning, and extending CI workflows to include Windows. Update documentation to reflect these changes and include Python as a new requirement.
New Features:
Enhancements:
CI:
Documentation: