Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve panic messages if retrieving/parsing GL_VERSION fails #331

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Improve panic messages if retrieving/parsing GL_VERSION fails #331

merged 2 commits into from
Jan 3, 2025

Conversation

josephcsible
Copy link
Contributor

No description provided.

@grovesNL
Copy link
Owner

grovesNL commented Jan 2, 2025

Hi! These panics aren't expected to be hit, is there any browser/device combination that would panic here?

@josephcsible
Copy link
Contributor Author

josephcsible commented Jan 2, 2025 •
edited
Loading

I'm not the one who hit it ,but see https://news.ycombinator.com/item?id=42514389
So "the mobile version of Brave".

grovesNL
grovesNL approved these changes Jan 3, 2025
View reviewed changes
Copy link
Owner

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - I'll have to check mobile Brave to see how we can support that better. Thanks!

@grovesNL grovesNL merged commit 32a527d into grovesNL:main Jan 3, 2025
7 checks passed
@josephcsible josephcsible deleted the patch-1 branch January 3, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grovesNL grovesNL grovesNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephcsible @grovesNL