Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Javadoc changes for io.grpc.LoadBalancer method signatures #11623

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open
Changes from 12 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
ab97045
SynchronizationContextTest changes for scheduleFixedDelay with Duration
SreeramdasLavanya Sep 20, 2024
fef4c92
Revert "SynchronizationContextTest changes for scheduleFixedDelay wit…
SreeramdasLavanya Sep 20, 2024
778cfb4
Merge branch 'grpc:master' into master
SreeramdasLavanya Sep 23, 2024
328bcbf
Merge branch 'grpc:master' into master
SreeramdasLavanya Sep 24, 2024
6a66054
Merge branch 'grpc:master' into master
SreeramdasLavanya Sep 26, 2024
4113845
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 1, 2024
09c3509
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 8, 2024
62a88ec
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 9, 2024
f658685
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 11, 2024
c51a5e4
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 15, 2024
02e92c5
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 17, 2024
4c31880
api: Javadoc changes for LoadBalancer method signatures
SreeramdasLavanya Oct 17, 2024
9ddcb09
api: Changes for UNAVAILABLE to Status.UNAVAILABLE and Status.OK
SreeramdasLavanya Oct 21, 2024
596d11d
api: Check style fix for UNAVAILABLE to Status.UNAVAILABLE and Status.OK
SreeramdasLavanya Oct 21, 2024
d9bf85e
api: Check style fix for Status.UNAVAILABLE and Status.OK
SreeramdasLavanya Oct 21, 2024
401a7d2
api: Check style fix for Status.UNAVAILABLE
SreeramdasLavanya Oct 21, 2024
f388ac2
api: Check style fix for Status.UNAVAILABLE
SreeramdasLavanya Oct 21, 2024
6e4efc7
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 25, 2024
cb315f0
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Oct 25, 2024
18b74c0
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 28, 2024
380345c
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Oct 28, 2024
846eb00
api/util/services: Deprected handleResolvedAddresses method and relat…
SreeramdasLavanya Oct 28, 2024
ee36c4e
interop-testing: Changes for deprecated handleResolvedAddresses metho…
SreeramdasLavanya Oct 29, 2024
b1f857f
xds: Changes for deprecated handleResolvedAddresses method and relate…
SreeramdasLavanya Oct 29, 2024
d236b88
Merge branch 'grpc:master' into master
SreeramdasLavanya Oct 30, 2024
891b547
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Oct 30, 2024
6d3abf0
api: Reverted changes for LoadBalancer and LoadBalancerTest
SreeramdasLavanya Nov 4, 2024
ca3e613
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 4, 2024
f9ffbc6
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 4, 2024
47002fe
util: Replaced handleResolvedAddress to acceptResolvedAddresses.
SreeramdasLavanya Nov 4, 2024
cb85563
api: Reverted back to acceptResolvedAddress
SreeramdasLavanya Nov 5, 2024
b44e402
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 6, 2024
8bfedb0
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 6, 2024
b9cced0
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 7, 2024
66a3495
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 7, 2024
45d3c75
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 8, 2024
b67b7ab
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 12, 2024
1b0ddaa
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 14, 2024
cfaab92
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 18, 2024
a0e5bf2
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 19, 2024
35f0769
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 22, 2024
bddc31c
Merge branch 'grpc:master' into master
SreeramdasLavanya Nov 25, 2024
b9a49a0
Merge branch 'master' into FixIssue-11194
SreeramdasLavanya Nov 25, 2024
1e6fef9
api/util: Addressed the re-review points
SreeramdasLavanya Nov 25, 2024
1674b6d
api/util: Resolved Deprecation warnings
SreeramdasLavanya Nov 25, 2024
60b4a39
api/util: Resolved checkstyle issues
SreeramdasLavanya Nov 25, 2024
8b02cd4
api/util: Resolved deprecation warnings
SreeramdasLavanya Nov 26, 2024
d746ef8
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Nov 26, 2024
516e75b
util/xds: Resolved deprecation warnings
SreeramdasLavanya Nov 26, 2024
36ecadb
util: Resolved deprecation warnings
SreeramdasLavanya Nov 26, 2024
d756690
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Dec 3, 2024
d2e6f04
util: Included suppress warnings for updateChildrenWithResolvedAddres…
SreeramdasLavanya Dec 3, 2024
4a690a2
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Dec 9, 2024
8c75ed0
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Dec 10, 2024
4b542f7
Merge branch 'grpc:master' into FixIssue-11194
SreeramdasLavanya Jan 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions api/src/main/java/io/grpc/LoadBalancer.java
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,11 @@ public String toString() {
private int recursionCount;

/**
* Handles newly resolved server groups and metadata attributes from name resolution system.
* {@code servers} contained in {@link EquivalentAddressGroup} should be considered equivalent
* but may be flattened into a single list if needed.
* Handles newly resolved addresses and metadata attributes from name resolution system.
* {@link EquivalentAddressGroup} addresses should be considered equivalent but may be flattened
ejona86 marked this conversation as resolved.
Show resolved Hide resolved
* into a single list if needed.
*
* <p>Implementations should not modify the given {@code servers}.
* <p>Implementations should not modify the given {@code resolvedAddresses}.
ejona86 marked this conversation as resolved.
Show resolved Hide resolved
*
* @param resolvedAddresses the resolved server addresses, attributes, and config.
* @since 1.21.0
Expand All @@ -179,12 +179,12 @@ public void handleResolvedAddresses(ResolvedAddresses resolvedAddresses) {
* EquivalentAddressGroup} addresses should be considered equivalent but may be flattened into a
* single list if needed.
*
* <p>Implementations can choose to reject the given addresses by returning {@code false}.
* <p>Implementations can choose to reject the given addresses by returning {@code UNAVAILABLE}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with {@code Status.UNAVAILABLE} . Also below.

*
* <p>Implementations should not modify the given {@code addresses}.
* <p>Implementations should not modify the given {@code resolvedAddresses}.
*
* @param resolvedAddresses the resolved server addresses, attributes, and config.
* @return {@code true} if the resolved addresses were accepted. {@code false} if rejected.
* @return {@code OK} if the resolved addresses were accepted. {@code UNAVAILABLE} if rejected.
* @since 1.49.0
*/
public Status acceptResolvedAddresses(ResolvedAddresses resolvedAddresses) {
Expand Down