Add NIOTS transport to E2E TLS-enabled tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
force-pushed
the
niots-e2e-tests
branch
from
50fd8c2 to
911a95e
Compare
glbrntt
reviewed
Dec 5, 2024
Sources/GRPCNIOTransportCore/Server/Connection/ServerConnectionManagementHandler.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift
Outdated
Show resolved
Hide resolved
gjcairo
force-pushed
the
niots-e2e-tests
branch
from
8020179 to
a5c3b05
Compare
gjcairo
force-pushed
the
niots-e2e-tests
branch
from
a5c3b05 to
2127ad6
Compare
glbrntt
requested changes
Dec 9, 2024
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportNIOTransportServicesTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift
Outdated
Show resolved
Hide resolved
glbrntt
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Some flakiness may be present on these tests. This should be fixed with apple/swift-nio-http2#483, but we'll have to update the package version once a new version is tagged.