Separate out the security config from the rest of the transport config #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Users must explicitly state whether they want TLS or plaintext. This config for this is currently nested within the rest of the config for the transport. In many cases this results in users writing `.defaults(transportSecurity: .tls(.defaults(...)))` where `.defaults(...)` often includes various TLS config. This is verbose and a little bit finicky to use. Modifications: - Seprate out the transport security from the rest of the config and have the client and server transport take a config _and_ a transport security config. - This allows for APIs which compose better while also allowing for the transport config to just use a set of defaults. Result: Easier to use API.
gjcairo
approved these changes
Dec 4, 2024
glbrntt
added
⚠️ semver/major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Users must explicitly state whether they want TLS or plaintext. This config for this is currently nested within the rest of the config for the transport. In many cases this results in users writing
.defaults(transportSecurity: .tls(.defaults(...)))where.defaults(...)often includes various TLS config. This is verbose and a little bit finicky to use.Modifications:
Result:
Easier to use API.