Use JSON (de)serializers instead of custom ones for tests #2162
+48
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
force-pushed
the
small-test-fix
branch
2 times, most recently
from
6d7af98 to
17d01a5
Compare
glbrntt
requested changes
Jan 17, 2025
Tests/GRPCInProcessTransportTests/Test Utilities/JSONSerializing.swift
Outdated
Show resolved
Hide resolved
gjcairo
force-pushed
the
small-test-fix
branch
from
17d01a5 to
ec70f7d
Compare
gjcairo
force-pushed
the
small-test-fix
branch
from
ec70f7d to
5810234
Compare
glbrntt
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests, we were using a custom serializer/deserializer to deal with the
PeerInfotype. We can just reuse the JSON (de)serialiser we have. Had to copy it over as it was in a different target.