Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fully switch to GuCDK instead of YAML. #2975

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

AshCorr
Copy link
Member

@AshCorr AshCorr commented Nov 18, 2024

What does this change?

Switch fully over to GuCDK instead of YAML.

This allows us to use Guardian standard patterns/configs and brings us more inline with Department recommendations.

For this Migration I've kept most of the defaults specified by the GuNodeApp pattern. Below lists all of the following changes impacted by using GuNodeApp:

  • AutoScalingGroup
    • HealthCheckGracePeriod reduced from 300 seconds to 120 seconds. Gateway starts fairly quickly so we don't need more than the default 120 seconds.
    • AutoScaling metrics enabled. Has a minimal cost impact from recording a few more cloudwatch metrics.
  • LoadBalancer
    • Deletion protection enabled. Load Balancers are stateful so it would be pretty bad if it was deleted.
    • Enable dropping invalid headers. Amazon defines Invalid Headers as headers that dont match the regex [-A-Za-z0-9]+ (only alphanumeric characters and hyphens allowed) which shouldn't apply to any of our headers (will double check before merging)
    • Reduced deregistration delay from 45 seconds to 30. This controls how long AWS will wait for connections to drain from an instance before removing it from the loadbalancer, since Gateway doesn't do any kind of polling most connections open and close within a few seconds, so a long delay is unecessary.
  • Security Groups
    • Remove inbound/outbound rules for port 443 between the Load Balancer and the EC2 instance. Gateway uses port 9233 for HTTP traffic.

How to test

Deploy to CODE.

@AshCorr AshCorr force-pushed the ash/more-cdk branch 2 times, most recently from b40c92e to 818388e Compare November 19, 2024 10:39
@AshCorr AshCorr force-pushed the ash/more-cdk branch 14 times, most recently from 9d1cd67 to a73b26b Compare November 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant