Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edit-ship-form.tsx to add delete prompt to user #739

Closed
wants to merge 7 commits into from

Conversation

kokojkj
Copy link

@kokojkj kokojkj commented Nov 13, 2024

No description provided.

Copy link

vercel bot commented Nov 13, 2024

@kokojkj is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:26pm

@scooterthedev
Copy link
Member

scooterthedev commented Nov 13, 2024

Hi! Besides for having a red alert going off in my brain for AI generated code (though I'm not making any accusations), this code seems to have removed all the edit options besides for the delete section. We still need to user to be able to edit there ship form, not just delete it ;). Also, the Github worflow is not needed, as it will be auto-deployed to vercel!

@kokojkj
Copy link
Author

kokojkj commented Nov 13, 2024

how to use Vercel to see if it running correctly ?

@scooterthedev
Copy link
Member

how to use Vercel to see if it running correctly ?

The way the system works I believe is that it will only work once deployed from them ie. Merged. Try fixing the code to the best of your ability and then someone from HC will look it over to make sure it will work before merging to main. Also just a side note, if you want to set it to a draft PR until the code is ready to be reviewed by HC that would help a lot and remove possible confusion on why a pr is half done!

@maxwofford
Copy link
Member

This PR just deletes a file and has no additions.

@kokojkj
Copy link
Author

kokojkj commented Nov 13, 2024

Iam just messing around and try to fix if i can sorry for time wasting my bad

@kokojkj kokojkj closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants