fix: rework splits and tabs to be usable with community #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidgetingbits
force-pushed
the
unify-with-community
branch
from
14b14ed to
1e9cf6c
Compare
fidgetingbits
force-pushed
the
unify-with-community
branch
from
1e9cf6c to
9539de9
Compare
fidgetingbits
force-pushed
the
unify-with-community
branch
4 times, most recently
from
792215d to
a9ad497
Compare
|
We need to discuss the changes you did for "split" |
saidelike
reviewed
Jun 4, 2024
fidgetingbits
force-pushed
the
unify-with-community
branch
3 times, most recently
from
7a71219 to
012c40a
Compare
fidgetingbits
changed the title
fidgetingbits
force-pushed
the
unify-with-community
branch
from
012c40a to
9e2348d
Compare
|
This should be in sync again. Because I'm using a different branch of neovim-talon, I'm testing there, and porting here. So it's possible some things will be a bit broken. |
fidgetingbits
force-pushed
the
unify-with-community
branch
2 times, most recently
from
0f531c7 to
6a85e09
Compare
|
This is a note to say that the move split to tab functions have changed and require an updated version of talon.nvim, which is still a PR hands-free-vim/talon.nvim#9 |
This was referenced Jun 14, 2024
Closed
saidelike
reviewed
Jul 18, 2024
fidgetingbits
force-pushed
the
unify-with-community
branch
from
6a85e09 to
b9b0399
Compare
fidgetingbits
force-pushed
the
unify-with-community
branch
from
b9b0399 to
5a048f8
Compare
|
What do you think about merging this (after fixing conflicts) so we benefit from the better code/APIs and if/when it finally gets reviewed in community we make the changes in a follow up PR? That way users could find bugs that may also benefit the community PR in the meantime? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes things to be usable with community.
Changed tags
This changes:
You will have to likely change this in your personal repo to match. Maybe it's something Andreas can do in his as well just to keep it more consistent.
Temporarily add split/tab commands
Until community PR 1147 and PR 1146 get merged, if we want all of the tab/split functionality I had from talon-vim working, we need to temporarily duplicate it in our own talon files.