chore: resolving comments

Signed-off-by: nikolay <[email protected]>

packages/relay/src/formatters.ts

@@ -267,7 +267,8 @@ const nanOrNumberTo0x = (input: number | BigNumber | bigint | null): string => {
 };
 
 const nanOrNumberInt64To0x = (input: number | BigNumber | bigint | null): string => {
-  if (input && input < 0) {
+  // converting to string and then back to int is fixing a typescript warning
+  if (input && parseInt(input.toString()) < 0) {
     // the hex of a negative number can be obtained from the binary value of that number positive value
     // the binary value needs to be negated and then to be incremented by 1
 
@@ -281,11 +282,11 @@ const nanOrNumberInt64To0x = (input: number | BigNumber | bigint | null): string
     // converting int16 -10 will be done as following:
     // - make it positive = 10
     // - 16 bits binary value of 10 = 0000 0000 0000 1010
-    // - inverse the bytes = 1111 1111 1111 0101
+    // - inverse the bits = 1111 1111 1111 0101
     // - adding +1 = 1111 1111 1111 0110
     // - 1111 1111 1111 0110 bits = 0xfff6
 
-    // we're using 64 bits integer because that the type returned by the mirror node - int64
+    // we're using 64 bits integer because that's the type returned by the mirror node - int64
     const bits = 64;
     return numberTo0x((BigInt(input.toString()) + (BigInt(1) << BigInt(bits))) % (BigInt(1) << BigInt(bits)));
   }

packages/relay/tests/lib/formatters.spec.ts

@@ -752,28 +752,31 @@ describe('Formatters', () => {
   });
 
   describe('tinybarsToWeibars', () => {
-    it('should convert tinybars to weibars', () => {
-      expect(tinybarsToWeibars(10)).to.eql(100000000000);
-    });
+    for (const allowNegativeValues of [true, false]) {
+      it(`should convert tinybars to weibars allowNegativeValues = ${allowNegativeValues}`, () => {
+        expect(tinybarsToWeibars(10, allowNegativeValues)).to.eql(100000000000);
+      });
 
-    it('should return null if null is passed', () => {
-      expect(tinybarsToWeibars(null)).to.eql(null);
-    });
+      it(`should return null if null is passed allowNegativeValues = ${allowNegativeValues}`, () => {
+        expect(tinybarsToWeibars(null, allowNegativeValues)).to.eql(null);
+      });
 
-    it('should return 0 for 0 input', () => {
-      expect(tinybarsToWeibars(0)).to.eql(0);
-    });
+      it(`should return 0 for 0 input allowNegativeValues = ${allowNegativeValues}`, () => {
+        expect(tinybarsToWeibars(0, allowNegativeValues)).to.eql(0);
+      });
+
+      it(`should throw an error when value is larger than the total supply of tinybars allowNegativeValues = ${allowNegativeValues}`, () => {
+        expect(() => tinybarsToWeibars(constants.TOTAL_SUPPLY_TINYBARS * 10, allowNegativeValues)).to.throw(
+          Error,
+          'Value cannot be more than the total supply of tinybars in the blockchain',
+        );
+      });
+    }
 
     it('should throw an error when value is smaller than 0', () => {
-      expect(() => tinybarsToWeibars(-10)).to.throw(Error, 'Invalid value - cannot pass negative number');
+      expect(() => tinybarsToWeibars(-10, false)).to.throw(Error, 'Invalid value - cannot pass negative number');
     });
 
-    it('should throw an error when value is larger than the total supply of tinybars', () => {
-      expect(() => tinybarsToWeibars(constants.TOTAL_SUPPLY_TINYBARS * 10)).to.throw(
-        Error,
-        'Value cannot be more than the total supply of tinybars in the blockchain',
-      );
-    });
     it('should return the negative number if allowNegativeValues flag is set to true', () => {
       expect(tinybarsToWeibars(-10, true)).to.eql(-10);
     });