Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve compatibility with standard ethereum tooling #2649

Conversation

konstantinabl
Copy link
Collaborator

@konstantinabl konstantinabl commented Jul 2, 2024

Description:

Currently, our validation process only checks the presence of fields returned by our API, without verifying the format of these fields. This can lead to inconsistencies and potential errors.

Changes introduced:

  • Adds separate CI workflow for API conformity
  • Pulls the openrpc.json from execution-apis repo in order to validate our response against it

Related issue(s):

Fixes #2108

@konstantinabl konstantinabl linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 2, 2024

Tests

       3 files     209 suites   16s ⏱️
1 057 tests 1 056 ✔️ 1 💤 0
1 069 runs  1 068 ✔️ 1 💤 0

Results for commit b17e573.

♻️ This comment has been updated with latest results.

@konstantinabl konstantinabl force-pushed the 2108-research-improve-compatility-with-standard-ethereum-tooling branch from fd097d9 to 1505dde Compare July 2, 2024 10:32
@konstantinabl konstantinabl changed the title Improve compatibility with standard ethereum tooling fix: Improve compatibility with standard ethereum tooling Jul 2, 2024
@konstantinabl konstantinabl force-pushed the 2108-research-improve-compatility-with-standard-ethereum-tooling branch from 1505dde to 0bb7a2f Compare July 2, 2024 10:43
Copy link

github-actions bot commented Jul 2, 2024

Acceptance Tests

  23 files  326 suites   35m 26s ⏱️
606 tests 569 ✔️ 4 💤 33
898 runs  855 ✔️ 6 💤 37

Results for commit b17e573.

♻️ This comment has been updated with latest results.

@konstantinabl konstantinabl force-pushed the 2108-research-improve-compatility-with-standard-ethereum-tooling branch 4 times, most recently from d10956d to 777a5d5 Compare July 3, 2024 14:59
@konstantinabl konstantinabl added the enhancement New feature or request label Jul 5, 2024
@konstantinabl konstantinabl marked this pull request as ready for review July 18, 2024 13:08
Copy link
Collaborator

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, after this we can write some custom tests for the schema. aside from Jeromy comments, i think it looks okay. @Nana-EC has to modify the checks when this is approved in order to be merged.

@konstantinabl konstantinabl force-pushed the 2108-research-improve-compatility-with-standard-ethereum-tooling branch 2 times, most recently from ad4382d to 824ed40 Compare July 22, 2024 12:54
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
…c; Adds file name in test header;Excludes dir from tests

Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
This reverts commit 38f712e.

Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl force-pushed the 2108-research-improve-compatility-with-standard-ethereum-tooling branch from 6ca3c0f to 3e78166 Compare August 19, 2024 14:23
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl force-pushed the 2108-research-improve-compatility-with-standard-ethereum-tooling branch from 1bb4895 to b7f486f Compare August 19, 2024 15:06
Signed-off-by: Konstantina Blazhukova <[email protected]>
Ivo-Yankov
Ivo-Yankov previously approved these changes Aug 26, 2024
Copy link
Collaborator

@Ivo-Yankov Ivo-Yankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Konstantina Blazhukova <[email protected]>
Copy link

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@konstantinabl konstantinabl merged commit bb36802 into main Aug 26, 2024
44 of 45 checks passed
@konstantinabl konstantinabl deleted the 2108-research-improve-compatility-with-standard-ethereum-tooling branch August 26, 2024 15:19
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (4ca9718) to head (b17e573).
Report is 18 commits behind head on main.

Files Patch % Lines
packages/server/src/validator/types.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2649      +/-   ##
==========================================
+ Coverage   80.14%   82.70%   +2.56%     
==========================================
  Files          30       47      +17     
  Lines        2709     3457     +748     
  Branches      582      731     +149     
==========================================
+ Hits         2171     2859     +688     
- Misses        344      371      +27     
- Partials      194      227      +33     
Flag Coverage Δ
relay 82.78% <ø> (+2.64%) ⬆️
server 81.22% <50.00%> (?)
ws-server 97.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/server/src/validator/constants.ts 100.00% <ø> (ø)
packages/server/src/validator/methods.ts 100.00% <ø> (ø)
packages/server/src/validator/types.ts 91.17% <50.00%> (ø)

... and 21 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Research: Improve compatility with standard Ethereum tooling
7 participants