feat: remove duplicated OFT Adapter section in LZ readme #3397
+4
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
natanasow
requested review from
georgi-l95,
Ivo-Yankov and
a team
as code owners
Test Results 20 files - 8 269 suites - 147 40m 2s ⏱️ - 51m 15s For more details on these failures, see this check. Results for commit b1238d0. ± Comparison against base commit e779b0f. ♻️ This comment has been updated with latest results. |
Signed-off-by: nikolay <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
- Coverage 84.87% 84.62% -0.26%
==========================================
Files 69 69
Lines 4742 4742
Branches 1067 1067
==========================================
- Hits 4025 4013 -12
- Misses 400 408 +8
- Partials 317 321 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, there are two sections regarding OFT Adapter, the first one covers ERC20/ERC20 case, the second one handles ERC20/HTS token. As long as they act the same, we let only one in the readme to avoid user confusion.
Related issue(s):
Fixes #3339
Notes for reviewer:
Checklist