Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: HIP-904 Additional e2e test cases where sender is a contract #17272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bubo
Copy link

@bubo bubo commented Jan 8, 2025

Description:
Adding some test cases for HIP-904 where sender is a contract

Related issue(s):

Fixes #
#16262
#16263
#16264
#16265
#16266
#16267
#16268

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@stoyanov-st stoyanov-st added this to the v0.59 milestone Jan 8, 2025
@stoyanov-st stoyanov-st closed this Jan 8, 2025
@stoyanov-st stoyanov-st reopened this Jan 8, 2025
@stoyanov-st stoyanov-st marked this pull request as ready for review January 9, 2025 08:54
@stoyanov-st stoyanov-st requested review from a team as code owners January 9, 2025 08:54
@stoyanov-st stoyanov-st requested a review from kimbor January 9, 2025 08:54
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.41%. Comparing base (293a28d) to head (e8c9221).
Report is 96 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17272      +/-   ##
============================================
+ Coverage     64.09%   67.41%   +3.31%     
- Complexity    20729    22063    +1334     
============================================
  Files          2543     2585      +42     
  Lines         95458    96408     +950     
  Branches       9993    10071      +78     
============================================
+ Hits          61187    64993    +3806     
+ Misses        30664    27698    -2966     
- Partials       3607     3717     +110     

see 456 files with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @bubo
LGTM

@bubo bubo force-pushed the HIP-904-Additional-e2e-tests branch from 92eb63c to e8c9221 Compare January 10, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants