Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Combine transaction.proto and transaction_body.proto into a single file #17361

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Jan 13, 2025

Description:
Implement option 2 from issue #17360

Related issue(s):

Fixes #17360

@kimbor kimbor self-assigned this Jan 13, 2025
Copy link

codacy-production bot commented Jan 13, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (46446f1) 96454 69071 71.61%
Head commit (7c836a9) 96454 (+0) 69129 (+58) 71.67% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17361) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (46446f1) to head (7c836a9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17361      +/-   ##
============================================
+ Coverage     67.73%   67.79%   +0.06%     
- Complexity    22199    22221      +22     
============================================
  Files          2594     2594              
  Lines         96671    96671              
  Branches      10081    10081              
============================================
+ Hits          65477    65539      +62     
+ Misses        27448    27390      -58     
+ Partials       3746     3742       -4     
Files with missing lines Coverage Δ
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 61.71% <ø> (ø)
...m/hedera/hapi/util/UnknownHederaFunctionality.java 100.00% <ø> (ø)
...edera/node/app/hapi/utils/CommonPbjConverters.java 68.44% <ø> (ø)
...e/addressbook/impl/handlers/NodeCreateHandler.java 98.03% <ø> (ø)
...e/addressbook/impl/handlers/NodeDeleteHandler.java 96.96% <ø> (ø)
...e/addressbook/impl/handlers/NodeUpdateHandler.java 95.94% <ø> (ø)
.../main/java/com/hedera/node/app/spi/AppContext.java 33.33% <ø> (ø)
.../hedera/node/app/spi/authorization/Authorizer.java 100.00% <ø> (ø)
...hedera/node/app/spi/workflows/DispatchOptions.java 100.00% <ø> (ø)
...m/hedera/node/app/spi/workflows/HandleContext.java 75.00% <ø> (ø)
... and 164 more

... and 16 files with indirect coverage changes

Impacted file tree graph

@kimbor kimbor changed the title feat: Delete deprecated field body from transaction.proto feat: Combine transaction.proto and transaction_body.proto into a single file Jan 14, 2025
@kimbor kimbor added this to the v0.60 milestone Jan 14, 2025
@kimbor kimbor marked this pull request as ready for review January 15, 2025 00:30
@kimbor kimbor requested review from a team and tinker-michaelj as code owners January 15, 2025 00:30
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for hedera-smart-contract-service-impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid circular dependency in hip-551 protobuf code
2 participants