Skip to content

Commit

Permalink
nit: cleanup
Browse files Browse the repository at this point in the history
Signed-off-by: Ivo Yankov <[email protected]>
  • Loading branch information
Ivo-Yankov committed Nov 8, 2024
1 parent ba50a7b commit c74f2e7
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
[![Codacy Badge](https://app.codacy.com/project/badge/Grade/83a423a3a1c942459127b3aec62ab0b5)](https://app.codacy.com/gh/hashgraph/solo/dashboard?utm_source=gh\&utm_medium=referral\&utm_content=\&utm_campaign=Badge_grade)
[![codecov](https://codecov.io/gh/hashgraph/solo/graph/badge.svg?token=hBkQdB1XO5)](https://codecov.io/gh/hashgraph/solo)

> [!WARNING]
> \[!WARNING]
> SPECIAL NOTICE: Introducing v1.0.0 comes with BREAKING CHANGES. We have removed caching of the flags in the solo config file. All commands will need required flags or user will need to answer the prompts. See more details in our release notes: [release/tag/v1.0.0](https://github.com/hashgraph/solo/releases/tag/v1.0.0)

An opinionated CLI tool to deploy and manage standalone test networks.

## Table of Contents
Expand Down
5 changes: 1 addition & 4 deletions src/commands/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,7 @@ export class InitCommand extends BaseCommand {
desc: 'Initialize local environment',
builder: (y: any) => {
flags.setCommandFlags(y,
flags.cacheDir,
flags.userEmailAddress,
flags.deploymentClusters,
flags.deploymentName
flags.cacheDir
)
},
handler: (argv: any) => {
Expand Down
2 changes: 1 addition & 1 deletion src/inject.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { constants } from './core/index.ts'
import { logging } from './core/index.ts'
import { type SoloLogger } from './core/logging.ts'
import { LocalConfig } from './core/config/LocalConfig.ts'
import { INJECTABLES } from './types/injectables.js'
import { INJECTABLES } from "./types/injectables.ts";

Check failure on line 24 in src/inject.config.ts

View workflow job for this annotation

GitHub Actions / Code Style / Standard

Strings must use singlequote

Check failure on line 24 in src/inject.config.ts

View workflow job for this annotation

GitHub Actions / Code Style / Standard

Extra semicolon

function getContainer () {
// TODO check if this creates a new container every time
Expand Down
6 changes: 2 additions & 4 deletions test/test_util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { describe, it, after, before } from 'mocha'
import fs from 'fs'
import os from 'os'
import path from 'path'
import { BaseCommand } from '../src/commands/base.ts'

Check failure on line 25 in test/test_util.ts

View workflow job for this annotation

GitHub Actions / Code Style / Standard

All imports in the declaration are only used as types. Use `import type`
import { ClusterCommand } from '../src/commands/cluster.ts'
import { InitCommand } from '../src/commands/init.ts'
import { NetworkCommand } from '../src/commands/network.ts'
Expand Down Expand Up @@ -59,7 +60,6 @@ import { SoloError } from '../src/core/errors.ts'
import { execSync } from 'child_process'
import * as NodeCommandConfigs from '../src/commands/node/configs.ts'
import type { SoloLogger } from '../src/core/logging.ts'
import type { BaseCommand } from '../src/commands/base.ts'
import type { NodeAlias } from '../src/types/aliases.ts'
import type { NetworkNodeServices } from '../src/core/network_node_services.ts'
import sinon from 'sinon'
Expand All @@ -69,10 +69,8 @@ export const testLogger = logging.NewLogger('debug', true)
export const TEST_CLUSTER = 'solo-e2e'
export const HEDERA_PLATFORM_VERSION_TAG = HEDERA_PLATFORM_VERSION

const TEST_DATA_DIR = 'test/data'

export function getTestCacheDir (testName?: string) {
const baseDir = `${TEST_DATA_DIR}/tmp`
const baseDir = 'test/data/tmp'
const d = testName ? path.join(baseDir, testName) : baseDir

if (!fs.existsSync(d)) {
Expand Down

0 comments on commit c74f2e7

Please sign in to comment.