Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_nginx_configuration - add content hash attribute to protected files #28532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valyria257
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The NGINXaaS API was updated to return protected files' virtual path and content hashes. It still does not return the file contents.

This updates the configuration resource and datasource by adding the new computed content_hash field.

It also updates how configurations are updated. Our API does a full update (CreateOrUpdate) when updating the configuration resource. Because of this, the request payload should include all fields. (https://github.com/hashicorp/terraform-provider-azurerm/blob/main/contributing/topics/best-practices.md#separate-create-and-update-methods)

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
$ make acctests SERVICE='nginx' TESTARGS='-run=TestAccConfiguration_' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/nginx -run=TestAccConfiguration_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccConfiguration_basic
=== PAUSE TestAccConfiguration_basic
=== RUN   TestAccConfiguration_withCertificate
=== PAUSE TestAccConfiguration_withCertificate
=== RUN   TestAccConfiguration_update
=== PAUSE TestAccConfiguration_update
=== RUN   TestAccConfiguration_requiresImport
=== PAUSE TestAccConfiguration_requiresImport
=== CONT  TestAccConfiguration_basic
=== CONT  TestAccConfiguration_update
=== CONT  TestAccConfiguration_withCertificate
=== CONT  TestAccConfiguration_requiresImport
--- PASS: TestAccConfiguration_requiresImport (516.17s)
--- PASS: TestAccConfiguration_basic (568.46s)
--- PASS: TestAccConfiguration_update (672.52s)
--- PASS: TestAccConfiguration_withCertificate (1059.85s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx 1066.499s
$ make acctests SERVICE='nginx' TESTARGS='-run=TestAccNginxConfigurationDataSource_' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/nginx -run=TestAccNginxConfigurationDataSource_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNginxConfigurationDataSource_basic
=== PAUSE TestAccNginxConfigurationDataSource_basic
=== CONT  TestAccNginxConfigurationDataSource_basic
--- PASS: TestAccNginxConfigurationDataSource_basic (500.42s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx 508.354s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_nginx_configuration - add content hash attribute to protected files

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

… files

The NGINXaaS API was updated to return protected files' virtual path and content hashes. It still does not return the file contents.

This updates the configuration resource and datasource by adding the new computed content_hash field.

It also updates how configurations are updated. Our API does a full update (CreateOrUpdate) when updating the configuration resource.
Because of this, the request payload should include all fields.
(https://github.com/hashicorp/terraform-provider-azurerm/blob/main/contributing/topics/best-practices.md#separate-create-and-update-methods)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant