-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an option to enable sAMAccountname logins when upndomain is set #29118
Merged
fairclothjm
merged 41 commits into
hashicorp:main
from
kwagga:ldap-add-samaccountname-login-option
Jan 24, 2025
Merged
Adds an option to enable sAMAccountname logins when upndomain is set #29118
fairclothjm
merged 41 commits into
hashicorp:main
from
kwagga:ldap-add-samaccountname-login-option
Jan 24, 2025
+49
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/kwagga/vault into ldap-add-samaccountname-login-option
….com/kwagga/vault into ldap-add-samaccountname-login-option
elliesterner
previously approved these changes
Jan 23, 2025
fairclothjm
previously approved these changes
Jan 23, 2025
not very familiar with this code base but added as a required reviewer automatically, approving in confidence of the other reviews |
clemon
previously approved these changes
Jan 23, 2025
schavis
reviewed
Jan 23, 2025
Co-authored-by: Sarah Chavis <[email protected]>
kwagga
dismissed stale reviews from clemon, fairclothjm, and elliesterner
via
January 23, 2025 20:02
1ac7f61
schavis
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content changes lgtm
elliesterner
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Active Directory allows LDAP binds as
userprincipalname@upndomain
as well assamaccountname@updomain
.With the current LDAP filter
samaccountname
logins fail when theupndomain
configuration parameter is set, since the filter only only checks foruserprincipalname=username@updomain
.This PR provides an
enable_samaccountname_login
option that can be set in the LDAP Authentication method. This will cause the LDAP user search filter to match eitheruserprincipalname
orsamaccountname
attributes instead of just theuserprincipalname
when theupndomain
configuration parameter is set.This PR relies on hashicorp/cap#146
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.