Fix Static Role Name Consistency in PostgreSQL Configuration #29138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… role name is consistent. The role name specified in allowed_roles="my-role" under the section "Rootless Configuration and Password Rotation for Static Roles" should align with the static role name in step hashicorp#3. Previously, the command incorrectly used "my-static-role"; it should be "my-role" to match the earlier step. The same role name should also be used when reading the static credentials in step hashicorp#4
|
|
heatherezell
added
secret/database/postgresql
bug
yhyakuna
previously approved these changes
Dec 17, 2024
akshya96
reviewed
Jan 9, 2025
changelog/29138.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| ```release-note:improvement | |||
There was a problem hiding this comment.
Since the change is specific to docs update only, changelog entry is not required.
|
Set this to auto-merge, but it'll need approval from the docs team. Looks good, but needed to delete the changelog. |
jonathanfrappier
approved these changes
Jan 16, 2025
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Role name is inconsistent in "Rootless Configuration and Password Rotation for Static Roles" Section
The role name specified in allowed_roles="my-role" under the section "Rootless Configuration and Password Rotation for Static Roles" should align with the static role name in step #3. Previously, the command incorrectly used "my-static-role"; it should be "my-role" to match the earlier step.
The same role name should also be used when reading the static credentials in step #4
Description
What does this PR do?
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.