Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.18.x UI: LDAP Hierarchical Library names #29390

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Backport 1.18.x UI: LDAP Hierarchical Library names #29390

merged 2 commits into from
Jan 23, 2025
+523 −243

Conversation

hellobontempo
Copy link
Contributor

Description

Manual backport #29293

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo
UI: LDAP Hierarchical Library names (#29293)
263d595 
* refactor crumbs

* add subdirectory library route and hierarchical nav

* update library breadcrumbs;

* fix role popup menus

* add getter to library model for full path

* cleanup model getters

* add changelog

* add bug fix note

* add transition after deleting

* fix function definition

* update adapter test

* add test coverage

* fix crumb typo
@hellobontempo hellobontempo added the backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent label Jan 23, 2025
@hellobontempo hellobontempo added this to the 1.18.4 milestone Jan 23, 2025
@hellobontempo hellobontempo requested a review from a team as a code owner January 23, 2025 00:25
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 23, 2025
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

Monkeychip
Monkeychip previously approved these changes Jan 23, 2025
View reviewed changes
@hellobontempo hellobontempo merged commit c483533 into release/1.18.x Jan 23, 2025
24 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x branch January 23, 2025 18:27
@hellobontempo hellobontempo changed the title Backport 1.18.x UI: LDAP Hierarchical Library names (#29293) Backport 1.18.x UI: LDAP Hierarchical Library names Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.18.4
Development

Successfully merging this pull request may close these issues.
2 participants
@hellobontempo @Monkeychip