Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of actions: pin to the latest approved workflows into release/1.18.x #29411

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #29321 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@ryancragun
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

The genesis of this PR is updating our cache action due to older actions being shut down0. While not mentioned in the changelog, the migration guide does call out versions <3.4.0 or <4.2.0 as too old.1

Since I was updating cache I went ahead and updated minor versions of all our actions.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

Copy link

hashicorp-cla-app bot commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 24, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

@ryancragun ryancragun force-pushed the backport/ryan/update-workflow-pins/usefully-new-python branch from 2a885da to bb889ca Compare January 24, 2025 22:07
@ryancragun ryancragun marked this pull request as ready for review January 24, 2025 22:07
@ryancragun ryancragun requested a review from a team as a code owner January 24, 2025 22:07
The genesis of this PR is updating our cache action due to older actions
being shut down[0]. While not mentioned in the changelog, the migration
guide does call out versions <3.4.0 or <4.2.0 as too old.[1]

Since I was updating cache I went ahead and updated minor versions of
all our actions.

[0]: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
[1]: actions/cache#1510

Signed-off-by: Ryan Cragun <[email protected]>
@ryancragun ryancragun force-pushed the backport/ryan/update-workflow-pins/usefully-new-python branch from bb889ca to 83cc669 Compare January 24, 2025 22:08
@ryancragun
Copy link
Collaborator

    deleted by us:   .github/actions/run-apupgrade-tests/action.yml
    deleted by us:   .github/workflows/benchmark-prevent-performance-degradations.yml
    both modified:   .github/workflows/ci.yml

Copy link

Build Results:
All builds succeeded! ✅

@ryancragun ryancragun merged commit fc39986 into release/1.18.x Jan 24, 2025
91 of 92 checks passed
@ryancragun ryancragun deleted the backport/ryan/update-workflow-pins/usefully-new-python branch January 24, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants