alterF: Skip deleting the key when it's already absent (#288)

Fixes #287.
haskell-unordered-containers · Jul 21, 2020 · f508e18 · f508e18
1 parent 6f1a92f
commit f508e18
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Data/HashMap/Internal.hs b/Data/HashMap/Internal.hs
@@ -1282,7 +1282,7 @@ alterF f = \ !k !m ->
     mv = lookup' h k m
   in (<$> f mv) $ \fres ->
     case fres of
-      Nothing -> delete' h k m
+      Nothing -> maybe m (const (delete' h k m)) mv
       Just v' -> insert' h k v' m
 
 -- We unconditionally rewrite alterF in RULES, but we expose an

diff --git a/Data/HashMap/Internal/Strict.hs b/Data/HashMap/Internal/Strict.hs
@@ -314,7 +314,7 @@ alterF f = \ !k !m ->
       mv = lookup' h k m
   in (<$> f mv) $ \fres ->
     case fres of
-      Nothing -> delete' h k m
+      Nothing -> maybe m (const (delete' h k m)) mv
       Just !v' -> insert' h k v' m
 
 -- We rewrite this function unconditionally in RULES, but we expose