Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comment #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/spl-utils/src/transaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ export async function bulkSendTransactions(
return ret;
}

// Returns the list of succesfully sent txns
// Returns the list of successfully sent txns
// NOTE: The return signatures are ordered by confirmation, not by order they are passed
// This list should be in order. Seom txns may fail
// due to blockhash exp
Expand Down
2 changes: 1 addition & 1 deletion packages/sus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ console.log(result)

## Human-readable Writable Accounts (and changes)

On Solana, every transaciton must declare which accounts can be changed over the course of a transaction. This is an important way to detect bad behavior. If a transaction is meant to swap SOL for HNT and it labels your USDC account as writable, this is a problem!
On Solana, every transaction must declare which accounts can be changed over the course of a transaction. This is an important way to detect bad behavior. If a transaction is meant to swap SOL for HNT and it labels your USDC account as writable, this is a problem!

Transaction simulation is not a silver bullet, it can be tricked. We cannot rely on simulated balance changes to reflect what _can_ happen in a transaction. As such, we should flag which important accounts are at risk.

Expand Down
2 changes: 1 addition & 1 deletion packages/sus/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ export async function sus({
});
}

// Catch malicious sol ownwer change
// Catch malicious sol owner change
const sysProg = new PublicKey("11111111111111111111111111111111");
const postOwner = acc.post.account?.owner || sysProg;
const preOwner = acc.pre.account?.owner || sysProg;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export const useRelinquishVote = (proposal: PublicKey) => {
if (marker && canRelinquishVote) {
if (position.isProxiedToMe) {
if (marker.proxyIndex < (position.proxy?.index || 0)) {
// Do not vote with a position that has been delegated to us, but voting overidden
// Do not vote with a position that has been delegated to us, but voting overridden
return;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/voter-stake-registry-hooks/src/hooks/useVote.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export const useVote = (proposalKey: PublicKey) => {
(marker.proxyIndex < (position.proxy?.index || 0) ||
marker.choices.includes(choice))
) {
// Do not vote with a position that has been delegated to us, but voting overidden
// Do not vote with a position that has been delegated to us, but voting overridden
// Also ignore voting for the same choice twice
return;
}
Expand Down
2 changes: 1 addition & 1 deletion programs/lazy-transactions/src/canopy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ pub fn fill_in_proof_from_canopy(
node_idx >>= 1;
}
// We only want to add inferred canopy nodes such that the proof length
// is equal to the tree depth. If the lengh of proof + lengh of canopy nodes is
// is equal to the tree depth. If the length of proof + length of canopy nodes is
// less than the tree depth, the instruction will fail.
let overlap = (proof.len() + inferred_nodes.len()).saturating_sub(max_depth as usize);
proof.extend(inferred_nodes.iter().skip(overlap));
Expand Down
18 changes: 9 additions & 9 deletions utils/vehnt/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.