Merge pull request #714 from helixml/disable_llm_calls_logging

Disable llm calls logging
helixml · Jan 15, 2025 · a0b16fc · a0b16fc
2 parents 182401f + 85d8f90
commit a0b16fc
Show file tree

Hide file tree

Showing 6 changed files with 38 additions and 19 deletions.
diff --git a/api/cmd/helix/serve.go b/api/cmd/helix/serve.go
@@ -282,20 +282,17 @@ func serve(cmd *cobra.Command, cfg *config.ServerConfig) error {
 
 	helixInference := openai.NewInternalHelixServer(cfg, ps, scheduler)
 
-	// controllerOpenAIClient, err := createOpenAIClient(cfg, helixInference)
-	// if err != nil {
-	// 	return err
-	// }
-
-	logStores := []logger.LogStore{
-		store,
-		// TODO: bigquery
+	var logStores []logger.LogStore
+
+	if !cfg.DisableLLMCallLogging {
+		logStores = []logger.LogStore{
+			store,
+			// TODO: bigquery
+		}
 	}
 
 	providerManager := manager.NewProviderManager(cfg, helixInference, logStores...)
 
-	// controllerOpenAIClient = logger.Wrap(cfg, controllerOpenAIClient, logStores...)
-
 	dataprepOpenAIClient, err := createDataPrepOpenAIClient(cfg, helixInference)
 	if err != nil {
 		return err

diff --git a/api/pkg/config/config.go b/api/pkg/config/config.go
@@ -29,6 +29,8 @@ type ServerConfig struct {
 	Apps               Apps
 	GPTScript          GPTScript
 	Triggers           Triggers
+
+	DisableLLMCallLogging bool `envconfig:"DISABLE_LLM_CALL_LOGGING" default:"false"`
 }
 
 func LoadServerConfig() (ServerConfig, error) {

diff --git a/api/pkg/server/handlers.go b/api/pkg/server/handlers.go
@@ -204,6 +204,7 @@ func (apiServer *HelixAPIServer) getConfig() (types.ServerConfigForFrontend, err
 		RudderStackDataPlaneURL: apiServer.Cfg.Janitor.RudderStackDataPlaneURL,
 		ToolsEnabled:            apiServer.Cfg.Tools.Enabled,
 		AppsEnabled:             apiServer.Cfg.Apps.Enabled,
+		DisableLLMCallLogging:   apiServer.Cfg.DisableLLMCallLogging,
 		Version:                 data.GetHelixVersion(),
 	}, nil
 }
@@ -222,11 +223,13 @@ func (apiServer *HelixAPIServer) configJS(res http.ResponseWriter, _ *http.Reque
 	}
 	res.Header().Set("Content-Type", "application/javascript")
 	content := fmt.Sprintf(`
+window.DISABLE_LLM_CALL_LOGGING = %t
 window.HELIX_SENTRY_DSN = "%s"
 window.HELIX_GOOGLE_ANALYTICS = "%s"
 window.RUDDERSTACK_WRITE_KEY = "%s"
 window.RUDDERSTACK_DATA_PLANE_URL = "%s"
 `,
+		config.DisableLLMCallLogging,
 		config.SentryDSNFrontend,
 		config.GoogleAnalyticsFrontend,
 		config.RudderStackWriteKey,

diff --git a/api/pkg/types/types.go b/api/pkg/types/types.go
@@ -686,6 +686,7 @@ type ServerConfigForFrontend struct {
 	AppsEnabled             bool   `json:"apps_enabled"`
 	RudderStackWriteKey     string `json:"rudderstack_write_key"`
 	RudderStackDataPlaneURL string `json:"rudderstack_data_plane_url"`
+	DisableLLMCallLogging   bool   `json:"disable_llm_call_logging"`
 	Version                 string `json:"version"`
 }
 

diff --git a/frontend/src/components/app/AppLogsTable.tsx b/frontend/src/components/app/AppLogsTable.tsx
@@ -22,6 +22,8 @@ interface AppLogsTableProps {
   appId: string;
 }
 
+const win = (window as any)
+
 const AppLogsTable: FC<AppLogsTableProps> = ({ appId }) => {
   const api = useApi();
   const [llmCalls, setLLMCalls] = useState<PaginatedLLMCalls | null>(null);
@@ -112,8 +114,13 @@ const AppLogsTable: FC<AppLogsTableProps> = ({ appId }) => {
             </TableRow>
           </TableHead>
           <TableBody>
-            {llmCalls.calls.map((call: LLMCall) => (
-              <TableRow key={call.id}>
+            { win.DISABLE_LLM_CALL_LOGGING ? (
+              <TableRow>
+                <TableCell colSpan={6}>LLM call logging is disabled by the administrator.</TableCell>
+              </TableRow>
+            ) : (
+              llmCalls.calls.map((call: LLMCall) => (
+                <TableRow key={call.id}>
                 <TableCell>{new Date(call.created).toLocaleString()}</TableCell>
                 <TableCell>{call.session_id}</TableCell>
                 <TableCell>{call.step || 'n/a'}</TableCell>
@@ -128,8 +135,9 @@ const AppLogsTable: FC<AppLogsTableProps> = ({ appId }) => {
                 <TableCell>
                   <Button onClick={() => handleOpenModal(call.response, call)}>View</Button>
                 </TableCell>
-              </TableRow>
-            ))}
+                </TableRow>
+              ))
+            )}
           </TableBody>
         </Table>
       </TableContainer>

diff --git a/frontend/src/components/dashboard/LLMCallsTable.tsx b/frontend/src/components/dashboard/LLMCallsTable.tsx
@@ -30,6 +30,8 @@ const LLMCallsTable: FC<LLMCallsTableProps> = ({ sessionFilter }) => {
   const [modalContent, setModalContent] = useState<any>(null);
   const [modalOpen, setModalOpen] = useState(false);
 
+  const win = (window as any)
+
   const fetchLLMCalls = async () => {
     try {
       const queryParams = new URLSearchParams({
@@ -99,9 +101,14 @@ const LLMCallsTable: FC<LLMCallsTableProps> = ({ sessionFilter }) => {
             </TableRow>
           </TableHead>
           <TableBody>
-            {llmCalls.calls.map((call: LLMCall) => (
-              <TableRow key={call.id}>
-                <TableCell>{call.id}</TableCell>
+            { win.DISABLE_LLM_CALL_LOGGING ? (
+              <TableRow>
+                <TableCell colSpan={6}>LLM call logging is disabled by the administrator.</TableCell>
+              </TableRow>
+            ) : (
+              llmCalls.calls.map((call: LLMCall) => (
+                <TableRow key={call.id}>
+                  <TableCell>{call.id}</TableCell>
                 <TableCell>{new Date(call.created).toLocaleString()}</TableCell>
                 <TableCell>{call.session_id}</TableCell>
                 <TableCell>{call.interaction_id}</TableCell>
@@ -120,8 +127,9 @@ const LLMCallsTable: FC<LLMCallsTableProps> = ({ sessionFilter }) => {
                 <TableCell>
                   <Button onClick={() => handleOpenModal(call.response)}>View</Button>
                 </TableCell>
-              </TableRow>
-            ))}
+                </TableRow>
+              ))
+            )}
           </TableBody>
         </Table>
       </TableContainer>