Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed token input symbol and address overlap #56

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

alvarengathomas
Copy link

Closes #50

This PR includes:

  • Fixes on token input layout to avoid the symbol to overlap the token address;

Here is a screenshot showing the fix:
Captura de Tela 2024-12-02 às 16 50 16

However, the same text is used to show errors like the following screenshot:
Captura de Tela 2024-12-02 às 16 51 17

@dvnahuel What should I do about the error messages? Please let me know in the PR comments.

Copy link

@gabmontes gabmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the solution.

@dvnahuel may want to continue suggesting ways to improve the usability.

@alvarengathomas alvarengathomas merged commit 6ce7009 into master Dec 2, 2024
6 checks passed
@alvarengathomas alvarengathomas deleted the fix-overlap-text branch December 2, 2024 22:58
@dvnahuel
Copy link

dvnahuel commented Dec 16, 2024

Hey team! just opened an issue that expands on this. Link
cc: @alvarengathomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token input overlap
4 participants