-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sentry #622
Merged
Merged
Add sentry #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabmontes
reviewed
Oct 24, 2024
gabmontes
approved these changes
Oct 24, 2024
ArturDolzan
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Sentry to allow for error-tracking. You can see the first commit doing that ccea18c
The second commit e25070a adds the sentry domains to the allow list in the security headers. For testing it locally (which I Was unable to do before), I updated the format so the headers are defined in a serve.json file. This way, I found the way I was setting the headers for using an allowlist to download/fetch from was incorrect, so I also fixed that. The
.htaccess
is now generated from that file as well (so we generate theserve.json
file for hosting locally usingserve
, and the.htaccess
forhostinger
). A note you will see in that commit is that we had to hardcode the list of RPC URLs, due to the difficulty in retrieving them fromhemi-viem
mixing ESM and CJS filesRelated issue(s)
Closes #553
Related to #617
Checklist