Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split deposit file into 2 components #729

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Split deposit file into 2 components #729

merged 4 commits into from
Jan 3, 2025

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented Jan 2, 2025

Description

As part of implementing custom external tunnels, I am adding these small changes so the PR is easier to review. The changes are:

  • 98aaa44 creates a DrawerTitle component
  • 534b0e5 Fixes an eslint warning on a test
  • 911dc72 splits deposit.tsx into evmDeposit.tsx and btcDeposit.tsx
  • b504484 fixes a variable name

Screenshots

No visible changes to the user

Related issue(s)

Related to. #719

Checklist

  • Manual testing passed.
  • Automated tests added, or N/A.
  • Documentation updated, or N/A.
  • Environment variables set in CI, or N/A.

@gndelia gndelia self-assigned this Jan 2, 2025
@gndelia gndelia requested a review from gabmontes as a code owner January 2, 2025 18:49
ArturDolzan
ArturDolzan approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ArturDolzan ArturDolzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uACK

@gndelia gndelia merged commit d23bba5 into main Jan 3, 2025
6 checks passed
@gndelia gndelia deleted the split-deposit-file branch January 3, 2025 13:23
@gndelia gndelia mentioned this pull request Jan 3, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturDolzan ArturDolzan ArturDolzan approved these changes

@rafappelt rafappelt rafappelt approved these changes

@gabmontes gabmontes gabmontes approved these changes

@alvarengathomas alvarengathomas Awaiting requested review from alvarengathomas

Assignees

@gndelia gndelia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gndelia @gabmontes @rafappelt @ArturDolzan