Bitcoin withdrawals pt3 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gndelia
force-pushed
the
bitcoin-withdrawals-pt3
branch
from
0d169c9 to
51cdca7
Compare
alvarengathomas
previously approved these changes
Jan 15, 2025
gndelia
dismissed stale reviews from gabmontes and alvarengathomas
via
5f194eb
gndelia
force-pushed
the
bitcoin-withdrawals-pt3
branch
from
51cdca7 to
5f194eb
Compare
ArturDolzan
approved these changes
Jan 15, 2025
gabmontes
approved these changes
Jan 15, 2025
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Follow up of #740
This PR focuses on adding the workers who watch the past bitcoin withdrawals for the status change (for example: if a withdrawal wasn't completed, it should after some time specified by the vault, be marked as ready to be challenged to restore the hemi bitcoins). This also includes some UI changes in the Transaction History page
Description per commit
4664d63 Implements the appropriate status and CTA for bitcoin withdrawals (updatin the prior implementation)
92a2970 prevents
getEvmTransactionReceiptto throw if the receipt was not found, returning null instead. There are some scenarios where we need this to be handled like this68d89dd moves a function to a
commonfile as it is needed in a few different files (naming is hard)144976f adds a few small tests for
isDeposit5412441 Makes a small update to the chain configuration for syncing.
8061476 Adds a minor improvement on the typings for enabling logs for debug in workers
1859fce adds a function that, given a withdrawal, gets the state (And any missing information, if any). This is used to watch bitcoin withdrawals by polling. Tests added too.
5f194eb Uses the function in the commit above to create a worker whenever there are withdrawals that need to be tracked and tracks them.
Lastly, cae161e fixes the conflicts after rebasing with Added sorting and filters to Transaction History #741
Screenshots
See #740
Related issue(s)
Related #738
Related #345
Checklist