Merge pull request #17 from grongor/fix-int-productids

Fix unintentional string to int conversion - Fixes #13
heureka · Apr 28, 2016 · 11f6d99 · 11f6d99
2 parents fdc4611 + b979cdc
commit 11f6d99
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/ShopCertification.php b/src/ShopCertification.php
@@ -125,13 +125,13 @@ public function addProductItemId($productItemId)
     {
         $productItemId = (string)$productItemId;
 
-        if (isset($this->productItemIds[$productItemId])) {
+        if (array_search($productItemId, $this->productItemIds) !== false) {
             throw new DuplicateProductItemIdException(
                 'The productItemId "%s" was already added. Please check the implementation.'
             );
         }
 
-        $this->productItemIds[$productItemId] = true;
+        $this->productItemIds[] = $productItemId;
 
         return $this;
     }
@@ -160,7 +160,7 @@ public function logOrder()
             $data['orderId'] = $this->orderId;
         }
 
-        $data['productItemIds'] = array_keys($this->productItemIds);
+        $data['productItemIds'] = $this->productItemIds;
 
         $result = $this->requester->request(IRequester::ACTION_LOG_ORDER, $data);
         if ($result->code !== 200) {

diff --git a/tests/ShopCertificationTest.php b/tests/ShopCertificationTest.php
@@ -54,7 +54,7 @@ public function testLogOrderSuccess()
 
         $requester->shouldReceive('request')
             ->once()
-            ->with(IRequester::ACTION_LOG_ORDER, $data)
+            ->with(IRequester::ACTION_LOG_ORDER, Mockery::mustBe($data))
             ->andReturn($response);
 
         $shopCertification = new ShopCertification($apiKey, [], $requester);
@@ -87,7 +87,7 @@ public function testLogOrderSuccessWithoutOptionalFields()
 
         $requester->shouldReceive('request')
             ->once()
-            ->with(IRequester::ACTION_LOG_ORDER, $data)
+            ->with(IRequester::ACTION_LOG_ORDER, Mockery::mustBe($data))
             ->andReturn($response);
 
         $shopCertification = new ShopCertification($apiKey, [], $requester);
@@ -133,7 +133,7 @@ public function testLogOrderFailure()
 
         $requester->shouldReceive('request')
             ->once()
-            ->with(IRequester::ACTION_LOG_ORDER, $data)
+            ->with(IRequester::ACTION_LOG_ORDER, Mockery::mustBe($data))
             ->andReturn($response);
 
         $shopCertification = new ShopCertification($apiKey, [], $requester);
@@ -168,7 +168,7 @@ public function testLogOrderDoubleSend()
 
         $requester->shouldReceive('request')
             ->once()
-            ->with(IRequester::ACTION_LOG_ORDER, $data)
+            ->with(IRequester::ACTION_LOG_ORDER, Mockery::mustBe($data))
             ->andReturn($response);
 
         $shopCertification = new ShopCertification($apiKey, [], $requester);