Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locks and nixpkgs #441

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Update locks and nixpkgs #441

merged 5 commits into from
Jan 3, 2025

Conversation

ThetaSinner
Copy link
Member

No description provided.

Copy link
Collaborator

@c12i c12i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏽

@ThetaSinner
Copy link
Member Author

This doesn't look like something I've broken?

@c12i
Copy link
Collaborator

c12i commented Jan 3, 2025

Hmm, seems that that home 0.5.11 requires rustc 1.81, this is despite downgrading to 0.5.9. Think another nix flake update should fix this?

@ThetaSinner
Copy link
Member Author

ThetaSinner commented Jan 3, 2025

No.. that won't fix it. The Rust version is pinned in Holonix deliberately. We don't update the Rust version on maintenance versions as a general rule. This is the actual generated hApp that has problems because of the old wasmer version. I've fixed this on the latest wasmer version so we don't depend on the home library.

@c12i
Copy link
Collaborator

c12i commented Jan 3, 2025

Hmm yes, I remember that 0.3 is on 1.78. Let me have a look at this further locally then

@ThetaSinner
Copy link
Member Author

I think upgrading wasmer on 0.3 is too big a risk. I'm tempted to suggest we pin home. Trying that out

@ThetaSinner
Copy link
Member Author

That seems to solve the problem locally, let's see if the CI agrees :)

@c12i c12i merged commit 44f003e into develop-0.3 Jan 3, 2025
11 checks passed
@c12i c12i deleted the update-locks-and-nixpkgs branch January 3, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants