Replace InstallValue and InstallGobalFunction by BindGlobal #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. in many cases. Note that `InstallValue` is a somewhat dangerous operation that we hope to phase out in GAP on the long run.
fingolfin
force-pushed
the
mh/InstallValue
branch
from
75c8146 to
6b76144
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 70.57% 70.52% -0.06%
==========================================
Files 439 437 -2
Lines 72200 72069 -131
==========================================
- Hits 50957 50827 -130
+ Misses 21243 21242 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in many cases. Note that
InstallValueis a somewhat dangerous operation that we hope to phase out in GAP on the long run.See also gap-system/gap#1637 for some background