fix: secretの元をコミットする必要はなかった

secretをコミットすると後から書き換えてもArgoCDが空の値で上書きしてしまう
honahuku · Dec 12, 2023 · ec66a93 · ec66a93
1 parent 5a2ad64
commit ec66a93
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 16 deletions.
diff --git a/connect/README.md b/connect/README.md
@@ -7,7 +7,12 @@
 ただ 1password operetor が secret を注入するために 1password.com にアクセスする際の secret は最初に手動でデプロイする必要がある  
 
 ```bash
-kubectl create secret -n connect generic op-credentials --from-file=1password-credentials.json=./1password-credentials.json
-kubectl create secret -n connect generic onepassword-token --from-literal=token="OP_CONNECT_TOKEN"
+kubectl create secret generic op-credentials \
+-n connect \
+--from-file=1password-credentials.json=1password-credentials.json \
+--dry-run=client -o yaml | kubectl apply -f -
+
+kubectl create secret generic onepassword-token -n connect \
+--from-literal=token="OP_CONNECT_TOKEN" | kubectl apply -f -
 ```
 
diff --git a/connect/base/kustomization.yaml b/connect/base/kustomization.yaml
@@ -5,8 +5,6 @@ namespace: connect
 
 resources:
   - namespace.yaml
-  - onepassword-token.yaml
-  - op-credentials.yaml
 
 helmCharts:
   - name: connect

diff --git a/connect/base/onepassword-token.yaml b/connect/base/onepassword-token.yaml
diff --git a/connect/base/op-credentials.yaml b/connect/base/op-credentials.yaml