Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update module name and fix README title #139

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Cleans up the dynamic sampler after it was added so it can be imported correctly.

Short description of the changes

  • Update the module name by removing the/processor/ part of the path
  • Update the README title

@MikeGoldsmith MikeGoldsmith added the type: bug Something isn't working label Aug 27, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Aug 27, 2024
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner August 27, 2024 12:15
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured the title should match the name.

dynamicsamplingprocessor/README.md Outdated Show resolved Hide resolved
Co-authored-by: Kent Quirk <[email protected]>
@MikeGoldsmith MikeGoldsmith merged commit 62059d4 into main Aug 27, 2024
4 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/dyn-sampler-cleanup branch August 27, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants