maint: DO NOT MERGE experiment with duration as a hist #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Which problem is this PR solving? Refinery loses the original user agent of the sending application because it aggregates spans until a trace decision is made. This PR records the original user agent for both HTTP and gRPC requests to the event, batch and OTLP trace/log endpoints in a new metadata field `meta.refinery.incoming_user_agent`. - Closes #1356 ## Short description of the changes - Update event, batch, OTLP trace/logs endpoints to record original user agent in new field - Update tests to verify events have the new field set - Add defer for bad API key test to restore allowed keys so subsequent tests can pass # Conflicts: # app/app_test.go # route/route.go
## Which problem is this PR solving? - If someone sends a big trace where one of the sampler keys is a high-cardinality field, Refinery could generate a huge sampler key value. This causes problems both for refinery but also the downstream telemetry. Let's not do that. ## Short description of the changes - Put a limit of 100 unique values to make up any one sampler key. Even that is big and probably useless but it should avoid any real use cases. - Add a test to show it works. Fixes #1363 --------- Co-authored-by: Mike Goldsmth <[email protected]>
## Which problem is this PR solving? Following up to the following PR, we should only set the incoming user agent if the key does not already exist. This is useful in certain scenarios when two Refinery's are connected together. - #1358 ## Short description of the changes - Only set incoming user agent meta field if the event doesn't already have a value for it - Add unit test to verify behaviour - Update existing tests to set custom user-agent and verify it's set correctly # Conflicts: # app/app_test.go # route/route_test.go
## Which problem is this PR solving? When there's a big volume of traffic, collector can take longer to respond to the health check ## Short description of the changes - add a new config option `HealthCheckTimeout` in `Collection` --------- Co-authored-by: Tyler Helmuth <[email protected]> # Conflicts: # config/metadata/configMeta.yaml
## Which problem is this PR solving? Prepares the 2.8.3 release. ## Short description of the changes - Add change log entry - Add release notes entry
## Which problem is this PR solving? - Closes #1335 ## Short description of the changes - Add bool case to ConvertNumeric - Add test for ConvertNumeric function
## Which problem is this PR solving? Prepares the v2.8.3 release. ## Short description of the changes - Add change log entry - Add release notes entry
TylerHelmuth
force-pushed
the
tyler.investigate-collect
branch
from
3fe56e3 to
ae12669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.