Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Switch metric to be a histogram #1380

Closed
wants to merge 1 commit into from
Closed

fix: Switch metric to be a histogram #1380

wants to merge 1 commit into from

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

  • Recording the value as a guage meant that a lot of values were missed as the older values got overwritten by newer values. This meant the largest value in the interval may not get exported.

Short description of the changes

  • Switch from gauge to histogram to make sure max values are captured.

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner October 11, 2024 15:15
@TylerHelmuth TylerHelmuth changed the title Switch metric to be a histogram fix: Switch metric to be a histogram Oct 11, 2024
@TylerHelmuth TylerHelmuth deleted the tyler.change-metric-to-hist branch October 11, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerHelmuth @VinozzZ